On Wed 17-02-21 16:27:27, Oscar Salvador wrote:

On 2021-02-17 16:06, Michal Hocko wrote:

quoted

I do not follow. You have successfully isolated huge pages so why don't
you add that page to the migratepages list to be migrated?

It is added. Note that I pass de list (cc->migratepages) to
isolate_or_dissolve_huge_page().
It is done this way because we have to pass the list to isolate_huge_page()
directly.
That is why I jump to isolate_success_no_list instead of isolate_sucess.

I know it is subtle, but I could not come up with a better name at that
time.

OK, I have missed that. Maybe just extend the comment. 

	/*
	 * Hugepage was succesfully isolated and on the tmigratepages
	 * list 
	 */
-- 
Michal Hocko
SUSE Labs