Thread (41 messages) 41 messages, 5 authors, 2021-02-10

Re: [RFC][PATCH 03/13] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks

From: Oscar Salvador <osalvador@suse.de>
Date: 2021-02-10 09:58:34
Also in: lkml

On Mon, Jan 25, 2021 at 04:34:17PM -0800, Dave Hansen wrote:
From: Dave Hansen <dave.hansen@linux.intel.com>

RECLAIM_ZONE was assumed to be unused because it was never explicitly
used in the kernel.  However, there were a number of places where it
was checked implicitly by checking 'node_reclaim_mode' for a zero
value.

These zero checks are not great because it is not obvious what a zero
mode *means* in the code.  Replace them with a helper which makes it
more obvious: node_reclaim_enabled().

This helper also provides a handy place to explicitly check the
RECLAIM_ZONE bit itself.  Check it explicitly there to make it more
obvious where the bit can affect behavior.

This should have no functional impact.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Ben Widawsky <redacted>
Acked-by: Christoph Lameter <redacted>
Cc: Alex Shi <redacted>
Cc: "Tobin C. Harding" <tobin@kernel.org>
Cc: Christoph Lameter <redacted>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Huang Ying <redacted>
Cc: Dan Williams <redacted>
Cc: Qian Cai <redacted>
Cc: Daniel Wagner <redacted>
Cc: osalvador <osalvador@suse.de>
Reviewed-by: Oscar Salvador <osalvador@suse.de>


-- 
Oscar Salvador
SUSE L3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help