Thread (9 messages) read the whole thread 9 messages, 2 authors, 2021-02-09

Re: [PATCH v4 4/5] mm: Use is_cow_mapping() across tree where proper

From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2021-02-09 18:14:27
Also in: lkml

On Mon, Feb 08, 2021 at 10:02:28PM -0500, Peter Xu wrote:
quoted hunk ↗ jump to hunk
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 71ccec5c3817..620700f05ff4 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3733,15 +3733,13 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
 	pte_t *src_pte, *dst_pte, entry, dst_entry;
 	struct page *ptepage;
 	unsigned long addr;
-	int cow;
+	int cow = is_cow_mapping(vma->vm_flags);
int should be bool

Otherwise looks fine to me 

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help