Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent
From: Nick Desaulniers <ndesaulniers@google.com>
Date: 2021-02-05 18:38:53
Also in:
lkml
On Wed, Dec 30, 2020 at 7:41 AM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de> clang cannt evaluate this function argument at compile time when the function is not inlined, which leads to a link time failure: ld.lld: error: undefined symbol: __compiletime_assert_414quoted
quoted
quoted
referenced by mremap.c mremap.o:(get_extent) in archive mm/built-in.aMark the function as __always_inline to avoid it. Fixes: 9ad9718bfa41 ("mm/mremap: calculate extent in one place") Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
quoted hunk ↗ jump to hunk
--- mm/mremap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)diff --git a/mm/mremap.c b/mm/mremap.c index c5590afe7165..1cb464a07184 100644 --- a/mm/mremap.c +++ b/mm/mremap.c@@ -336,8 +336,9 @@ enum pgt_entry { * valid. Else returns a smaller extent bounded by the end of the source and * destination pgt_entry. */ -static unsigned long get_extent(enum pgt_entry entry, unsigned long old_addr, - unsigned long old_end, unsigned long new_addr) +static __always_inline unsigned long get_extent(enum pgt_entry entry, + unsigned long old_addr, unsigned long old_end, + unsigned long new_addr) { unsigned long next, extent, mask, size; --2.29.2 -- You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20201230154104.522605-1-arnd%40kernel.org.
-- Thanks, ~Nick Desaulniers