Re: [PATCH v9 08/14] mm/gup: do not migrate zero page

Hi Pavel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kselftest/next]
[also build test ERROR on tip/sched/core tip/perf/core linux/master next-20210125]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pavel-Tatashin/prohibit-pinning-pages-in-ZONE_MOVABLE/20210201-234048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: arm-randconfig-r031-20210201 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 275c6af7d7f1ed63a03d05b4484413e447133269)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/0871f9d0d8c84d31549b4771af9d60ce3b1aecb2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pavel-Tatashin/prohibit-pinning-pages-in-ZONE_MOVABLE/20210201-234048
        git checkout 0871f9d0d8c84d31549b4771af9d60ce3b1aecb2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   In file included from arch/arm/kernel/asm-offsets.c:12:

quoted

include/linux/mm.h:1128:3: error: implicit declaration of function 'is_zero_pfn' [-Werror,-Wimplicit-function-declaration]

                   is_zero_pfn(page_to_pfn(page));
                   ^
   include/linux/mm.h:1128:3: note: did you mean 'is_zero_ino'?
   include/linux/fs.h:2926:20: note: 'is_zero_ino' declared here
   static inline bool is_zero_ino(ino_t ino)
                      ^
   1 error generated.
--
   In file included from arch/arm/kernel/asm-offsets.c:12:

quoted

include/linux/mm.h:1128:3: error: implicit declaration of function 'is_zero_pfn' [-Werror,-Wimplicit-function-declaration]

                   is_zero_pfn(page_to_pfn(page));
                   ^
   include/linux/mm.h:1128:3: note: did you mean 'is_zero_ino'?
   include/linux/fs.h:2926:20: note: 'is_zero_ino' declared here
   static inline bool is_zero_ino(ino_t ino)
                      ^
   1 error generated.
   make[2]: *** [scripts/Makefile.build:117: arch/arm/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1206: prepare0] Error 2
   make[1]: Target 'modules_prepare' not remade because of errors.
   make: *** [Makefile:185: __sub-make] Error 2
   make: Target 'modules_prepare' not remade because of errors.
--
   In file included from arch/arm/kernel/asm-offsets.c:12:

quoted

include/linux/mm.h:1128:3: error: implicit declaration of function 'is_zero_pfn' [-Werror,-Wimplicit-function-declaration]

                   is_zero_pfn(page_to_pfn(page));
                   ^
   include/linux/mm.h:1128:3: note: did you mean 'is_zero_ino'?
   include/linux/fs.h:2926:20: note: 'is_zero_ino' declared here
   static inline bool is_zero_ino(ino_t ino)
                      ^
   1 error generated.
   make[2]: *** [scripts/Makefile.build:117: arch/arm/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1206: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:185: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +/is_zero_pfn +1128 include/linux/mm.h

  1123	
  1124	/* MIGRATE_CMA and ZONE_MOVABLE do not allow pin pages */
  1125	static inline bool is_pinnable_page(struct page *page)
  1126	{
  1127		return !(is_zone_movable_page(page) || is_migrate_cma_page(page)) ||

1128			is_zero_pfn(page_to_pfn(page));

  1129	}
  1130	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org