Thread (2 messages) 2 messages, 2 authors, 2021-02-01

Re: [PATCH] mm/mempolicy: use helper range_in_vma() in queue_pages_test_walk()

From: David Hildenbrand <hidden>
Date: 2021-02-01 11:11:29
Also in: lkml

On 30.01.21 10:13, Miaohe Lin wrote:
quoted hunk ↗ jump to hunk
The helper range_in_vma() is introduced via commit 017b1660df89 ("mm:
migration: fix migration of huge PMD shared pages"). But we forgot to
use it in queue_pages_test_walk().

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
  mm/mempolicy.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 6961238c7ef5..ab51132547b8 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -677,7 +677,7 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end,
  	unsigned long flags = qp->flags;
  
  	/* range check first */
-	VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma);
+	VM_BUG_ON_VMA(!range_in_vma(vma, start, end), vma);
  
  	if (!qp->first) {
  		qp->first = vma;
Reviewed-by: David Hildenbrand <redacted>

-- 
Thanks,

David / dhildenb

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help