Re: [v7 PATCH 07/12] mm: vmscan: use a new flag to indicate shrinker is registered
From: Vlastimil Babka <hidden>
Date: 2021-02-10 18:26:47
Also in:
linux-fsdevel, lkml
From: Vlastimil Babka <hidden>
Date: 2021-02-10 18:26:47
Also in:
linux-fsdevel, lkml
On 2/9/21 6:46 PM, Yang Shi wrote:
Currently registered shrinker is indicated by non-NULL shrinker->nr_deferred. This approach is fine with nr_deferred at the shrinker level, but the following patches will move MEMCG_AWARE shrinkers' nr_deferred to memcg level, so their shrinker->nr_deferred would always be NULL. This would prevent the shrinkers from unregistering correctly. Remove SHRINKER_REGISTERING since we could check if shrinker is registered successfully by the new flag. Acked-by: Kirill Tkhai <redacted> Signed-off-by: Yang Shi <redacted>
Acked-by: Vlastimil Babka <redacted> With Roman's suggestion it's fine by me too.