Re: [PATCH 2/5] kernel/dma: remove unnecessary unmap_kernel_range
From: Konrad Rzeszutek Wilk <hidden>
Date: 2021-01-27 03:42:08
Also in:
linux-iommu, lkml
On Tue, Jan 26, 2021 at 02:54:01PM +1000, Nicholas Piggin wrote:
vunmap will remove ptes.
Should there be some ASSERT after the vunmap to make sure that is the case?
quoted hunk ↗ jump to hunk
Cc: Christoph Hellwig <hch@lst.de> Cc: Marek Szyprowski <m.szyprowski@samsung.com> Cc: Robin Murphy <robin.murphy@arm.com> Cc: iommu@lists.linux-foundation.org Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- kernel/dma/remap.c | 1 - 1 file changed, 1 deletion(-)diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c index 905c3fa005f1..b4526668072e 100644 --- a/kernel/dma/remap.c +++ b/kernel/dma/remap.c@@ -66,6 +66,5 @@ void dma_common_free_remap(void *cpu_addr, size_t size) return; } - unmap_kernel_range((unsigned long)cpu_addr, PAGE_ALIGN(size)); vunmap(cpu_addr); }-- 2.23.0 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu