Re: [PATCH v2 14/14] kasan: don't run tests when KASAN is not enabled

On Wed, Jan 13, 2021 at 5:39 PM Marco Elver [off-list ref] wrote:

On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov [off-list ref] wrote:

quoted

Don't run KASAN tests when it's disabled with kasan.mode=off to avoid
corrupting kernel memory.

Link: https://linux-review.googlesource.com/id/I6447af436a69a94bfc35477f6bf4e2122948355e
Signed-off-by: Andrey Konovalov <redacted>
---
 lib/test_kasan.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/test_kasan.c b/lib/test_kasan.c
index d9f9a93922d5..0c8279d9907e 100644
--- a/lib/test_kasan.c
+++ b/lib/test_kasan.c

@@ -47,6 +47,9 @@ static bool multishot;
  */
 static int kasan_test_init(struct kunit *test)
 {
+       if (!kasan_enabled())
+               return -1;

This should WARN_ON() or pr_err(). Otherwise it's impossible to say
why the test couldn't initialize.

Will do in v3, thanks!