Re: [PATCH] mm/page_alloc: remove the static for local variable node_order
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2021-01-04 23:24:39
Also in:
lkml
On Wed, 30 Dec 2020 12:42:33 +0000 Matthew Wilcox [off-list ref] wrote:
On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote:quoted
local variable node_order do not need the static here.It bloody well does. It can be up to 2^10 entries on x86 (and larger on others) That's 4kB which you've now moved onto the stack.
That being said, could we kmalloc the scratch area in __build_all_zonelists()? And maybe remove that static spinlock? (what blocks node and cpu hotplug in there??)