On 8/27/20 2:03 PM, Randy Dunlap wrote:

Hi,

I can't reproduce this with mmotm of 2020-08-25...

Hi Randy,

We can reproduce this error on the commit 4c4ef2c53
if following the reproduce steps:

   CC [M]  crypto/drbg.o
   CC      fs/buffer.o
In file included from ./arch/powerpc/include/asm/paca.h:18,
                  from ./arch/powerpc/include/asm/percpu.h:13,
                  from ./include/linux/random.h:14,
                  from ./include/crypto/drbg.h:43,
                  from crypto/drbg.c:100:
./arch/powerpc/include/asm/mmu.h:139:22: error: unknown type name 
'next_tlbcam_idx'
   139 | DECLARE_PER_CPU(int, next_tlbcam_idx);
       |                      ^~~~~~~~~~~~~~~
   CC      drivers/tty/serial/8250/8250_early.o
   CC      kernel/irq/spurious.o
   CC      mm/vmalloc.o
   CC [M]  net/netfilter/nf_nat_irc.o
   CC      drivers/lightnvm/core.o
   CC      net/ipv4/tcp_fastopen.o
make[1]: *** [scripts/Makefile.build:280: crypto/drbg.o] Error 1
make: *** [Makefile:1756: crypto] Error 2

More below.

On 8/24/20 7:11 PM, kernel test robot wrote:

quoted

tree:   https://github.com/hnaz/linux-mm master
head:   2932a9e66c580f3c8d95ec27716d437198fb4c94
commit: 4c4ef2c53a5e517248011bd1908235df1257e66d [1/421] origin
config: powerpc-ppc64e_defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         git checkout 4c4ef2c53a5e517248011bd1908235df1257e66d
         # save the attached .config to linux build tree
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

    In file included from arch/powerpc/include/asm/paca.h:18,
                     from arch/powerpc/include/asm/percpu.h:13,
                     from include/linux/random.h:14,
                     from include/linux/net.h:18,
                     from fs/cifs/netmisc.c:12:

quoted

quoted

arch/powerpc/include/asm/mmu.h:139:22: error: unknown type name 'next_tlbcam_idx'

That's not a type name. It's a variable name. The type is 'int'.

quoted

      139 | DECLARE_PER_CPU(int, next_tlbcam_idx);
          |                      ^~~~~~~~~~~~~~~
--
    In file included from arch/powerpc/include/asm/paca.h:18,
                     from arch/powerpc/include/asm/percpu.h:13,
                     from include/linux/random.h:14,
                     from include/linux/net.h:18,
                     from fs/cifs/netmisc.c:12:

quoted

quoted

arch/powerpc/include/asm/mmu.h:139:22: error: unknown type name 'next_tlbcam_idx'

      139 | DECLARE_PER_CPU(int, next_tlbcam_idx);
          |                      ^~~~~~~~~~~~~~~
    In file included from fs/cifs/cifsglob.h:32,
                     from fs/cifs/netmisc.c:22:
    fs/cifs/smb2pdu.h:28:10: fatal error: cifsacl.h: No such file or directory
       28 | #include <cifsacl.h>
          |          ^~~~~~~~~~~

#include <cifsacl.h>

That probably could be changed to "cifsacl.h".

quoted

    compilation terminated.

# https://github.com/hnaz/linux-mm/commit/4c4ef2c53a5e517248011bd1908235df1257e66d
git remote add hnaz-linux-mm https://github.com/hnaz/linux-mm
git fetch --no-tags hnaz-linux-mm master
git checkout 4c4ef2c53a5e517248011bd1908235df1257e66d
vim +/next_tlbcam_idx +139 arch/powerpc/include/asm/mmu.h

7c03d653cd2577 Benjamin Herrenschmidt 2008-12-18  136
3160b09796129a Becky Bruce            2011-06-28  137  #ifdef CONFIG_PPC_FSL_BOOK3E
3160b09796129a Becky Bruce            2011-06-28  138  #include <asm/percpu.h>
3160b09796129a Becky Bruce            2011-06-28 @139  DECLARE_PER_CPU(int, next_tlbcam_idx);
3160b09796129a Becky Bruce            2011-06-28  140  #endif
3160b09796129a Becky Bruce            2011-06-28  141

:::::: The code at line 139 was first introduced by commit
:::::: 3160b09796129abc9523ea3cd1633b0faba64a02 powerpc: Create next_tlbcam_idx percpu variable for FSL_BOOKE

It's surprising that a patch from 2011 would start showing problems now.

the commit 3160b09796 first introduced the related codes, but it doesn't 
mean the commit is a bad commit.

Best Regards,
Rong Chen

quoted

:::::: TO: Becky Bruce [off-list ref]
:::::: CC: Kumar Gala [off-list ref]