Thread (2 messages) 2 messages, 2 authors, 2020-06-01

Re: [PATCH] mm: Remove misleading comment

From: William Kucharski <hidden>
Date: 2020-06-01 12:15:23

quoted hunk ↗ jump to hunk
On May 29, 2020, at 6:32 AM, Matthew Wilcox [off-list ref] wrote:

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

We no longer return 0 here and the comment doesn't tell us anything
that we don't already know (SIGBUS is a pretty good indicator that
things didn't work out).

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
mm/filemap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 23a051a7ef0f..fe079e9219d1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
	if (!error || error == AOP_TRUNCATED_PAGE)
		goto retry_find;

-	/* Things didn't work out. Return zero to tell the mm layer so. */
	shrink_readahead_size_eio(ra);
	return VM_FAULT_SIGBUS;
Reviewed-by: William Kucharski <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help