Thread (12 messages) 12 messages, 3 authors, 2020-03-26

Re: [PATCH v7 1/9] fs: Constify vma argument to vma_is_dax

From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Date: 2020-03-26 07:20:02
Also in: dri-devel, lkml

quoted hunk ↗ jump to hunk
From: "Thomas Hellstrom (VMware)" <redacted>

The function is used by upcoming vma_is_special_huge() with which we want
to use a const vma argument. Since for vma_is_dax() the vma argument is
only dereferenced for reading, constify it.

Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: "Kirill A. Shutemov" <redacted>
Cc: Ralph Campbell <redacted>
Cc: "Jérôme Glisse" <redacted>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Dan Williams <redacted>
Signed-off-by: Thomas Hellstrom (VMware) <redacted>
Reviewed-by: Roland Scheidegger <redacted>
Acked-by: Christian König <christian.koenig@amd.com>
---
 include/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 3cd4fe6b845e..2b38ce5b73ad 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -3391,7 +3391,7 @@ static inline bool io_is_direct(struct file *filp)
        return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host);
 }

-static inline bool vma_is_dax(struct vm_area_struct *vma)
+static inline bool vma_is_dax(const struct vm_area_struct *vma)
 {
        return vma->vm_file && IS_DAX(vma->vm_file->f_mapping->host);
 }
--
Acked-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
2.21.1
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help