Thread (3 messages) 3 messages, 3 authors, 2020-02-27

Re: [PATCH] dmaengine: tegra-apb: fix platform_get_irq.cocci warnings

From: Dmitry Osipenko <digetx@gmail.com>
Date: 2020-02-27 14:50:25
Also in: linux-tegra

27.02.2020 13:35, Julia Lawall пишет:
quoted hunk ↗ jump to hunk
From: kbuild test robot <redacted>

Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: 6c41ac96ad92 ("dmaengine: tegra-apb: Support COMPILE_TEST")
CC: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: kbuild test robot <redacted>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f3fef7e990dae5fcd7cd8ccbd9b2a98bdb481da8
commit: 6c41ac96ad9217fe2a6f31c9dcc31b97365b21f6 [4196/4617] dmaengine: tegra-apb: Support COMPILE_TEST
:::::: branch date: 17 hours ago
:::::: commit date: 2 days ago

Please take the patch only if it's a positive warning. Thanks!

 tegra20-apb-dma.c |    1 -
 1 file changed, 1 deletion(-)
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -1477,7 +1477,6 @@ static int tegra_dma_probe(struct platfo
 		irq = platform_get_irq(pdev, i);
 		if (irq < 0) {
 			ret = irq;
-			dev_err(&pdev->dev, "No irq resource for chan %d\n", i);
 			goto err_pm_disable;
 		}
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help