Thread (3 messages) 3 messages, 3 authors, 2020-03-01

Re: [PATCH] mm/memblock: remove redundant assignment to variable max_addr

From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Date: 2020-02-29 07:47:37
Also in: kernel-janitors, lkml

quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted>

The variable max_addr is being initialized with a value that is never
read and it is being updated later with a new value.  The initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 mm/memblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index eba94ee3de0b..4d06bbaded0f 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1698,7 +1698,7 @@ static phys_addr_t __init_memblock __find_max_addr(phys_addr_t limit)

 void __init memblock_enforce_memory_limit(phys_addr_t limit)
 {
-       phys_addr_t max_addr = PHYS_ADDR_MAX;
+       phys_addr_t max_addr;

        if (!limit)
                return;
--
2.25.0
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help