Re: [RFC PATCH 2/2] mm: mmu_notifier fix for tlb_end_vma (build failures)
From: Guenter Roeck <linux@roeck-us.net>
Date: 2018-08-24 14:06:57
Also in:
linux-arch, linux-riscv, lkml
Subsystem:
mmu gather and tlb invalidation, risc-v architecture, the rest · Maintainers:
Will Deacon, "Aneesh Kumar K.V", Andrew Morton, Nick Piggin, Peter Zijlstra, Paul Walmsley, Palmer Dabbelt, Albert Ou, Linus Torvalds
On 08/24/2018 06:50 AM, Will Deacon wrote:
quoted
-#include <asm-generic/tlb.h> +struct mmu_gather; static inline void tlb_flush(struct mmu_gather *tlb) { flush_tlb_mm(tlb->mm);Bah, didn't spot the dereference so this won't work either. You basically just need to copy what I did for arm64 in d475fac95779.
Yes, this seems to work. It doesn't really need "struct mmu_gather;" - I assume that is included from elsewhere - but I added it to be safe. Can you send a full patch, or do you want me to do it ? Thanks, Guenter ---
diff --git a/arch/riscv/include/asm/tlb.h b/arch/riscv/include/asm/tlb.h
index c229509288ea..439dc7072e05 100644
--- a/arch/riscv/include/asm/tlb.h
+++ b/arch/riscv/include/asm/tlb.h@@ -14,6 +14,10 @@ #ifndef _ASM_RISCV_TLB_H #define _ASM_RISCV_TLB_H +struct mmu_gather; + +static void tlb_flush(struct mmu_gather *tlb); + #include <asm-generic/tlb.h> static inline void tlb_flush(struct mmu_gather *tlb)