Re: [PATCH 2/2] fs/dcache: Make negative dentries easier to be reclaimed

Another pet peeve ;)

On Tue, 28 Aug 2018 13:19:40 -0400 Waiman Long [off-list ref] wrote:

 /**
+ * list_lru_add_head: add an element to the lru list's head
+ * @list_lru: the lru pointer
+ * @item: the item to be added.
+ *
+ * This is similar to list_lru_add(). The only difference is the location
+ * where the new item will be added. The list_lru_add() function will add

People often use the term "the foo() function".  I don't know why -
just say "foo()"!

+ * the new item to the tail as it is the most recently used one. The
+ * list_lru_add_head() will add the new item into the head so that it

Ditto.

"to the head"

+ * will the first to go if a shrinker is running. So this function should

"will be the"

+ * only be used for less important item that can be the first to go if

"items"

+ * the system is under memory pressure.
+ *
+ * Return value: true if the list was updated, false otherwise
+ */