Re: [PATCH v2 5/6] mm: track gup pages with page->dma_pinned_* fields

From
Christopher Lameter <hidden>
Date
2018-07-03 17:08:12
Also in
linux-fsdevel, linux-rdma, lkml
Reply to
John Hubbard, 2018-07-03
On Mon, 2 Jul 2018, John Hubbard wrote:
quoted
If you establish a reference to a page then increase the page count. If
the reference is a dma pin action also then increase the pinned count.

That way you know how many of the references to the page are dma
pins and you can correctly manage the state of the page if the dma pins go
away.
I think this sounds like what this patch already does, right? See:
__put_page_for_pinned_dma(), __get_page_for_pinned_dma(), and
pin_page_for_dma(). The locking seems correct to me, but I suspect it's
too heavyweight for such a hot path. But without adding a new put_user_page()
call, that was the best I could come up with.
When I saw the patch it looked like you were avoiding to increment the
page->count field.
What I'm hearing now from Jan and Michal is that the desired end result is
a separate API call, put_user_pages(), so that we can explicitly manage
these pinned pages.
Certainly a good approach.
Thread (30 messages) 30 messages, 5 authors, last reply 2018-07-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help