Re: [PATCH 1/7] genalloc: track beginning of allocations

From
Matthew Wilcox <willy@infradead.org>
Date
2018-03-06 14:13:17
Also in
linux-security-module, lkml
Reply to
Mike Rapoport, 2018-03-06
On Tue, Mar 06, 2018 at 02:19:03PM +0100, Mike Rapoport wrote:
quoted
+/**
+ * gen_pool_create() - create a new special memory pool
+ * @min_alloc_order: log base 2 of number of bytes each bitmap entry
+ *		     represents
+ * @nid: node id of the node the pool structure should be allocated on,
+ *	 or -1
+ *
+ * Create a new special memory pool that can be used to manage special
+ * purpose memory not managed by the regular kmalloc/kfree interface.
+ *
+ * Return:
+ * * pointer to the pool	- success
+ * * NULL			- otherwise
+ */
If I'm not mistaken, several kernel-doc descriptions are duplicated now.
Can you please keep a single copy? ;-)
I think the problem is that Igor has chosen to put the kernel-doc with
the function declaration.  I think we usually recommend putting it with
the definition so it's more likely to be updated.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Thread (34 messages) 34 messages, 5 authors, last reply 2018-03-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help