Re: [PATCH v2] mm/zsmalloc: simplify shrinker init/destroy

On 12/20/2017 12:25 PM, Michal Hocko wrote:

On Wed 20-12-17 18:16:53, Sergey Senozhatsky wrote:

quoted

On (12/20/17 10:08), Michal Hocko wrote:
[..]

quoted

quoted

let's keep void zs_register_shrinker() and just suppress the
register_shrinker() must_check warning.

I would just hope we simply drop the must_check nonsense.

agreed. given that unregister_shrinker() does not oops anymore,
enforcing that check does not make that much sense.

Well, the registration failure is a failure like any others. Ignoring
the failure can have bad influence on the overal system behavior but
that is no different from thousands of other functions. must_check is an
overreaction here IMHO.

Fine, then I'll resend the patch with diff from Andrew, and also I'd like
to move the improved comment into zs_register_shrinker().

Best regards,
    Aliaksei.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>