Thread (4 messages) 4 messages, 4 authors, 2017-02-23

Re: [PATCH] mm/thp/autonuma: Use TNF flag instead of vm fault.

From: Hillf Danton <hidden>
Date: 2017-02-20 03:30:50
Also in: lkml

On February 19, 2017 6:00 PM Aneesh Kumar K.V wrote: 
We are using wrong flag value in task_numa_falt function. This can result in
us doing wrong numa fault statistics update, because we update num_pages_migrate
and numa_fault_locality etc based on the flag argument passed.

Signed-off-by: Aneesh Kumar K.V <redacted>
Fix: bae473a423 ("mm: introduce fault_env")
Acked-by: Hillf Danton <redacted>
quoted hunk ↗ jump to hunk
---
 mm/huge_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 5f3ad65c85de..8f1d93257fb9 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1333,7 +1333,7 @@ int do_huge_pmd_numa_page(struct vm_fault *vmf, pmd_t pmd)

 	if (page_nid != -1)
 		task_numa_fault(last_cpupid, page_nid, HPAGE_PMD_NR,
-				vmf->flags);
+				flags);

 	return 0;
 }
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help