Thread (36 messages) 36 messages, 7 authors, 2017-01-26

Re: [PATCH 01/12] uprobes: split THPs before trying replace them

From: Kirill A. Shutemov <hidden>
Date: 2017-01-24 22:56:30
Also in: lkml

On Tue, Jan 24, 2017 at 02:35:59PM -0800, Andrew Morton wrote:
On Wed, 25 Jan 2017 01:22:17 +0300 "Kirill A. Shutemov" [off-list ref] wrote:
quoted
On Tue, Jan 24, 2017 at 01:28:49PM -0800, Andrew Morton wrote:
quoted
On Tue, 24 Jan 2017 19:28:13 +0300 "Kirill A. Shutemov" [off-list ref] wrote:
quoted
For THPs page_check_address() always fails. It's better to split them
first before trying to replace.
So what does this mean.  uprobes simply fails to work when trying to
place a probe into a THP memory region?
Looks like we can end up with endless retry loop in uprobe_write_opcode().
quoted
How come nobody noticed (and reported) this when using the feature?
I guess it's not often used for anon memory.
OK,  can we please include discussion of these things in the changelog?
Okay, I'll try to come up with a test case too.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help