Re: [PATCH] mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf
From: Ross Zwisler <hidden>
Date: 2017-01-23 21:36:14
Also in:
linux-fsdevel, nvdimm
On Fri, Jan 20, 2017 at 04:33:08PM -0700, Dave Jiang wrote:
->fault(), ->page_mkwrite(), and ->pfn_mkwrite() calls do not need to take a vma and vmf parameter when the vma already resides in vmf. Remove the vma parameter to simplify things. Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- This patch has received a build success notification from the 0day-kbuild robot across 124 configs. ---
<>
quoted hunk ↗ jump to hunk
diff --git a/arch/x86/entry/vdso/vma.c b/arch/x86/entry/vdso/vma.c index 10820f6..b6661fd 100644 --- a/arch/x86/entry/vdso/vma.c +++ b/arch/x86/entry/vdso/vma.c@@ -38,7 +38,7 @@ void __init init_vdso_image(const struct vdso_image *image) struct linux_binprm; static int vdso_fault(const struct vm_special_mapping *sm, - struct vm_area_struct *vma, struct vm_fault *vmf) + struct vm_area_struct *vma, struct vm_fault *vmf)
Unneeded spacing change. Other than that, this looks good to me. I agree with Jan's observation that it creates a lot of thrash, but I personally like the change because it eliminates the question of what to do when the 'vma' you're passed in doesn't match 'vmf->vma'. Having one source of truth seems good, and it reduces the amount of args we are passing around. Reviewed-by: Ross Zwisler <redacted> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>