Re: [RFC PATCH] mm, memcg: fix (Re: OOM: Better, but still there on)
From: Michal Hocko <mhocko@kernel.org>
Date: 2016-12-26 12:48:47
Also in:
linux-btrfs, lkml
Subsystem:
control group - memory resource controller (memcg), memory management, memory management - core, memory management - mglru (multi-gen lru), memory management - reclaim, the rest · Maintainers:
Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt, Andrew Morton, David Hildenbrand, Linus Torvalds
On Fri 23-12-16 23:26:00, Nils Holland wrote:
On Fri, Dec 23, 2016 at 03:47:39PM +0100, Michal Hocko wrote:quoted
Nils, even though this is still highly experimental, could you give it a try please?Yes, no problem! So I kept the very first patch you sent but had to revert the latest version of the debugging patch (the one in which you added the "mm_vmscan_inactive_list_is_low" event) because otherwise the patch you just sent wouldn't apply. Then I rebooted with memory cgroups enabled again, and the first thing that strikes the eye is that I get this during boot: [ 1.568174] ------------[ cut here ]------------ [ 1.568327] WARNING: CPU: 0 PID: 1 at mm/memcontrol.c:1032 mem_cgroup_update_lru_size+0x118/0x130 [ 1.568543] mem_cgroup_update_lru_size(f4406400, 2, 1): lru_size 0 but not empty
Ohh, I can see what is wrong! a) there is a bug in the accounting in my patch (I double account) and b) the detection for the empty list cannot work after my change because per node zone will not match per zone statistics. The updated patch is below. So I hope my brain already works after it's been mostly off last few days... ---