Thread (8 messages) 8 messages, 4 authors, 2016-11-25

Re: [PATCH] z3fold: use %z modifier for format string

From: Vitaly Wool <hidden>
Date: 2016-11-25 07:35:55
Also in: lkml

Hi Arnd,

On Thu, Nov 24, 2016 at 5:31 PM, Arnd Bergmann [off-list ref] wrote:
Printing a size_t requires the %zd format rather than %d:

mm/z3fold.c: In function ‘init_z3fold’:
include/linux/kern_levels.h:4:18: error: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]

Fixes: 50a50d2676c4 ("z3fold: don't fail kernel build if z3fold_header is too big")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Vitaly Wool <redacted>

And thanks :)

~vitaly
quoted hunk ↗ jump to hunk
---
 mm/z3fold.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/z3fold.c b/mm/z3fold.c
index e282ba073e77..66ac7a7dc934 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -884,7 +884,7 @@ static int __init init_z3fold(void)
 {
        /* Fail the initialization if z3fold header won't fit in one chunk */
        if (sizeof(struct z3fold_header) > ZHDR_SIZE_ALIGNED) {
-               pr_err("z3fold: z3fold_header size (%d) is bigger than "
+               pr_err("z3fold: z3fold_header size (%zd) is bigger than "
                        "the chunk size (%d), can't proceed\n",
                        sizeof(struct z3fold_header) , ZHDR_SIZE_ALIGNED);
                return -E2BIG;
--
2.9.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help