Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()
From: zijun_hu <hidden>
Date: 2016-09-27 06:07:25
Also in:
lkml
From: zijun_hu <hidden>
Date: 2016-09-27 06:07:25
Also in:
lkml
On 09/22/2016 07:15 AM, David Rientjes wrote:
On Thu, 22 Sep 2016, zijun_hu wrote:quoted
quoted
We don't support inserting when va->va_start == tmp_va->va_end, plain and simple. There's no reason to do so. NACK to the patch.i am sorry i disagree with you because 1) in almost all context of vmalloc, original logic treat the special case as normal for example, __find_vmap_area() or alloc_vmap_area()The ranges are [start, end) like everywhere else. __find_vmap_area() is implemented as such for the passed address. The address is aligned in alloc_vmap_area(), there's no surprise here. The logic is correct in __insert_vmap_area().
i am sorry to disagree with you i will resend this patch with more detailed illustration -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>