Thread (7 messages) 7 messages, 2 authors, 2016-09-29

Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk()

From: Tejun Heo <tj@kernel.org>
Date: 2016-09-23 21:30:38
Also in: lkml

Hello,

On Sat, Sep 24, 2016 at 05:16:56AM +0800, zijun_hu wrote:
On 2016/9/24 3:23, Tejun Heo wrote:
quoted
On Sat, Sep 24, 2016 at 02:20:24AM +0800, zijun_hu wrote:
quoted
From: zijun_hu <redacted>

correct max_distance from (base of the highest group + ai->unit_size)
to (base of the highest group + the group size)

Signed-off-by: zijun_hu <redacted>
Nacked-by: Tejun Heo [off-list ref]

Thanks.
frankly, the current max_distance is error, doesn't represents the ranges spanned by
areas owned by the groups
I think you're right but can you please update the patch description
so that it explains what the bug and the implications are and how the
patch fixes the bug.  Also, please make sure that all changes made by
the patch are explained in the description - e.g. why the type of
@max_distance is changed from size_t to ulong.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help