Re: [PATCH 2/4] mm, compaction: more reliably increase direct compaction priority

On 09/22/2016 04:52 PM, Michal Hocko wrote:

On Thu 22-09-16 16:08:21, Michal Hocko wrote:

quoted

On Thu 22-09-16 14:51:48, Vlastimil Babka wrote:

quoted

quoted

From 465e1bd61b7a6d6901a44f09b1a76514dbc220fa Mon Sep 17 00:00:00 2001

From: Vlastimil Babka <redacted>
Date: Thu, 22 Sep 2016 13:54:32 +0200
Subject: [PATCH] mm, compaction: more reliably increase direct compaction
 priority-fix

When increasing the compaction priority, also reset retries. Otherwise we can
consume all retries on the lower priorities.

OK, this is an improvement. I am just thinking that we might want to
pull
	if (order && compaction_made_progress(compact_result))
		compaction_retries++;

into should_compact_retry as well. I've had it there originally because
it was in line with no_progress_loops but now that we have compaction
priorities it would fit into retry logic better. As a plus it would
count only those compaction rounds where we we didn't have to rely on

                                                 did that should be

quoted

the compaction retry logic. What do you think?

In that case I would also add this for consistency?

----8<----