On Mon, Sep 19, 2016 at 05:57:17PM -0700, David Rientjes wrote:

On Sun, 18 Sep 2016, Piotr Kwapulinski wrote:

quoted

The MPOL_F_STATIC_NODES and MPOL_F_RELATIVE_NODES flags are irrelevant
when setting them for MPOL_LOCAL NUMA memory policy via set_mempolicy.
Return the "invalid argument" from set_mempolicy whenever
any of these flags is passed along with MPOL_LOCAL.
It is consistent with MPOL_PREFERRED passed with empty nodemask.
It also slightly shortens the execution time in paths where these flags
are used e.g. when trying to rebind the NUMA nodes for changes in
cgroups cpuset mems (mpol_rebind_preferred()) or when just printing
the mempolicy structure (/proc/PID/numa_maps).
Isolated tests done.

Signed-off-by: Piotr Kwapulinski <redacted>

Acked-by: David Rientjes <rientjes@google.com>

There wasn't an MPOL_LOCAL when I introduced either of these flags, it's 
an oversight to allow them to be passed.

Want to try to update set_mempolicy(2) with the procedure outlined in 
https://www.kernel.org/doc/man-pages/patches.html as well?

Yes, why not ? I'll put a note about it.

--
Piotr Kwapulinski

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>