On Fri, 2016-09-09 at 15:36 +0300, Kirill A. Shutemov wrote:

On Thu, Sep 08, 2016 at 11:21:46PM +0000, Kani, Toshimitsu wrote:

quoted

On Thu, 2016-09-08 at 07:48 -0600, Kani, Toshimitsu wrote:

quoted

On Thu, 2016-09-08 at 13:57 +0300, Kirill A. Shutemov wrote:

quoted

On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu
wrote:

 :

quoted

quoted

quoted

Looking further, these shmem_huge handlings only check pre-
conditions.  So, we should be able to make shmem_get_unmapped
_are a() as a wrapper, which checks such shmem-specific
conitions, and then call __thp_get_unmapped_area() for the
actual work.  All DAX-specific checks are performed in
thp_get_unmapped_area() as well.  We can make
 __thp_get_unmapped_area() as a common
function.

I'd prefer to make such change as a separate item,

Do you have plan to submit such change?

Yes, I will submit the change once I finish testing.

I found a bug in the current code, and need some clarification.
 The if-statement below is reverted.

<two-hands-facepalm>

Yeah. It was repored by Hillf[1]. The fixup got lost. :(

Could you post a proper patch with the fix?

I would be nice to credit Hillf there too.

[1] http://lkml.kernel.org/r/054f01d1c86f$2994d5c0$7cbe8140$@alibaba-
inc.com

Yes, I will submit the fix as well.

I will not change the default value of sbinfo->huge in this fix.  So,
user will have to specify "huge=" option to enable huge page mappings.
 If this is not desireable, we will need a separate patch.

Thanks,
-Toshi

�{.n�+���zwZ��,j���n�˛���m�b��f�)���w+h����&�K�rJ+�Z+��ފw�r��L2Ǟ��i��0�X�����?��zf���ky���[hv�������zf��K�rJ+��