On 25.08.2016 00:22, Michal Hocko wrote:

On Wed 24-08-16 11:13:31, Ralf-Peter Rohbeck wrote:

quoted

On 19.08.2016 01:26, Michal Hocko wrote:

[...]

quoted

quoted

quoted

diff --git a/mm/compaction.c b/mm/compaction.c
index ae4f40afcca1..3e35fce2cace 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c

@@ -1644,8 +1644,8 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,
   		.alloc_flags = alloc_flags,
   		.classzone_idx = classzone_idx,
   		.direct_compaction = true,
-		.whole_zone = (prio == COMPACT_PRIO_SYNC_FULL),
-		.ignore_skip_hint = (prio == COMPACT_PRIO_SYNC_FULL)
+		.whole_zone = (prio == MIN_COMPACT_PRIORITY),
+		.ignore_skip_hint = (prio == MIN_COMPACT_PRIORITY)
   	};
   	INIT_LIST_HEAD(&cc.freepages);
   	INIT_LIST_HEAD(&cc.migratepages);

@@ -1691,7 +1691,7 @@ enum compact_result try_to_compact_pages(gfp_t gfp_mask, unsigned int order,
   								ac->nodemask) {
   		enum compact_result status;
-		if (prio > COMPACT_PRIO_SYNC_FULL
+		if (prio > MIN_COMPACT_PRIORITY
   					&& compaction_deferred(zone, order)) {
   			rc = max_t(enum compact_result, COMPACT_DEFERRED, rc);
   			continue;

-- 
2.9.2

This change was in linux-next-20160823 so I ran it unmodified.

I did get an OOM, see attached.

This patch shouldn't make any difference to the previous patch you were
testing. Anyway I do not have the above linux-next tag so I cannot check
what exactly was there. The current code in linux-next contains
https://urldefense.proofpoint.com/v2/url?u=http-3A__lkml.kernel.org_r_20160823074339.GB23577-40dhcp22.suse.cz&d=DQIBAg&c=8S5idjlO_n28Ko3lg6lskTMwneSC-WqZ5EBTEEvDlkg&r=yGQdEpZknbtYvR0TyhkCGu-ifLklIvXIf740poRFltQ&m=CNEWNMAovbVAu8gw1UooufVBqAK0HbH5FJskyAmkR1g&s=S-eqTOP5U79awF_vqBSGNfNrvOe5l60XzVoVa6DuWx4&e=  so a
different approach. Once that patch hits the Linus tree we will try to
resurrect the compaction improvements series in linux-next and continue
with the testing.

Sorry, the tag was next-20160823; I called the branch linux-next-20160823.


Ralf-Peter

----------------------------------------------------------------------
The information contained in this transmission may be confidential. Any disclosure, copying, or further distribution of confidential information is not permitted unless such privilege is explicitly granted in writing by Quantum. Quantum reserves the right to have electronic communications, including email and attachments, sent across its networks filtered through anti virus and spam software programs and retain such messages in order to comply with applicable data security and retention requirements. Quantum is not responsible for the proper and complete transmission of the substance of this communication or for any delay in its receipt.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>