Re: [PATCH] do_generic_file_read(): Fail immediately if killed
From: Oleg Nesterov <oleg@redhat.com>
Date: 2016-08-17 13:48:02
Also in:
linux-fsdevel
On 08/16, Bart Van Assche wrote:
If a fatal signal has been received, fail immediately instead of trying to read more data.
This looks a bit misleading to me. If wait_on_page_locked_killable() was interrupted then this page is most likely is not PageUptodate() and in this case do_generic_file_read() will fail after lock_page_killable(). But as I already said, I belive the change itself is fine,
quoted hunk ↗ jump to hunk
--- a/mm/filemap.c +++ b/mm/filemap.c@@ -1721,7 +1721,9 @@ find_page: * wait_on_page_locked is used to avoid unnecessarily * serialisations and why it's safe. */ - wait_on_page_locked_killable(page); + error = wait_on_page_locked_killable(page); + if (unlikely(error)) + goto readpage_error; if (PageUptodate(page)) goto page_ok;
Acked-by: Oleg Nesterov <oleg@redhat.com> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>