Re: [PATCH v3 5/9] tools/vm/page_owner: increase temporary buffer size
From: Vlastimil Babka <hidden>
Date: 2016-06-17 12:56:44
Also in:
lkml
On 06/17/2016 09:57 AM, js1304@gmail.com wrote:
From: Joonsoo Kim <redacted> Page owner will be changed to store more deep stacktrace so current temporary buffer size isn't enough. Increase it. Link: http://lkml.kernel.org/r/1464230275-25791-5-git-send-email-iamjoonsoo.kim@lge.com Signed-off-by: Joonsoo Kim <redacted> Cc: Vlastimil Babka <redacted>
Acked-by: Vlastimil Babka <redacted>
quoted hunk ↗ jump to hunk
Cc: Mel Gorman <redacted> Cc: Minchan Kim <minchan@kernel.org> Cc: Alexander Potapenko <glider@google.com> Cc: Hugh Dickins <hughd@google.com> Cc: Michal Hocko <mhocko@kernel.org> --- tools/vm/page_owner_sort.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c index 77147b4..f1c055f 100644 --- a/tools/vm/page_owner_sort.c +++ b/tools/vm/page_owner_sort.c@@ -79,12 +79,12 @@ static void add_list(char *buf, int len) } } -#define BUF_SIZE 1024 +#define BUF_SIZE (128 * 1024) int main(int argc, char **argv) { FILE *fin, *fout; - char buf[BUF_SIZE]; + char *buf; int ret, i, count; struct block_list *list2; struct stat st;@@ -107,6 +107,11 @@ int main(int argc, char **argv) max_size = st.st_size / 100; /* hack ... */ list = malloc(max_size * sizeof(*list)); + buf = malloc(BUF_SIZE); + if (!list || !buf) { + printf("Out of memory\n"); + exit(1); + } for ( ; ; ) { ret = read_block(buf, BUF_SIZE, fin);
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>