Re: [PATCH 7/8] pkeys: add details of system call use to Documentation/

On Wed, 1 Jun 2016 09:46:07 -0700
Dave Hansen [off-list ref] wrote:

On 06/01/2016 09:43 AM, Jonathan Corbet wrote:

quoted

quoted

quoted

+There are 5 system calls which directly interact with pkeys:
+
+	int pkey_alloc(unsigned long flags, unsigned long init_access_rights)
+	int pkey_free(int pkey);
+	int sys_pkey_mprotect(unsigned long start, size_t len,
+			      unsigned long prot, int pkey);
+	unsigned long pkey_get(int pkey);
+	int pkey_set(int pkey, unsigned long access_rights);  

sys_pkey_mprotect() should just be pkey_mprotect(), right?  

Yes, and that are a few more instances of that farther down in the file.
 I'll fix them all up.

While you're at it (I shouldn't have hit send quite so quickly :) 

+	sys_pkey_alloc(0, PKEY_DISABLE_WRITE | PKEY_DISABLE_READ);
+	sys_pkey_mprotect(ptr, size, PROT_READ|PROT_WRITE);
+	something(ptr);

That should, IMO, be something like:

	key = pkey_alloc(...);
	pkey_mprotect(ptr, size, PROT_READ|PROT_WRITE, key);

?


jon

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>