Re: [PATCH] mm,oom_reaper: don't call mmput_async() without atomic_inc_not_zero()
From: Michal Hocko <hidden>
Date: 2016-05-30 06:52:16
On Sat 28-05-16 17:16:05, Tetsuo Handa wrote:
Commit e2fe14564d3316d1 ("oom_reaper: close race with exiting task")
reduced frequency of needlessly selecting next OOM victim, but was
calling mmput_async() when atomic_inc_not_zero() failed.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>Acked-by: Michal Hocko <mhocko@suse.com> Thanks!
quoted hunk ↗ jump to hunk
--- mm/oom_kill.c | 1 + 1 file changed, 1 insertion(+)diff --git a/mm/oom_kill.c b/mm/oom_kill.c index dfb1ab6..0d781b8 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c@@ -478,6 +478,7 @@ static bool __oom_reap_task(struct task_struct *tsk) mm = p->mm; if (!atomic_inc_not_zero(&mm->mm_users)) { task_unlock(p); + mm = NULL; goto unlock_oom; }-- 1.8.3.1
-- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>