Re: [PATCH trivial] include/linux/gfp.h: Improve the coding styles
From: Chen Gang <hidden>
Date: 2016-02-25 22:16:36
Also in:
lkml
On 2/25/16 23:12, Jiri Kosina wrote:
On Thu, 25 Feb 2016, Chen Gang wrote:quoted
I can understand for your NAK, it is a trivial patch.Not all trivial patches are NAKed :) But they have to be generally useful. Shuffling code around, without actually changing / improving it a bit, just for the sole purpose of formatting, is kind of pointless (especially given the fact that the current code as-is is easily readable; it's not like it'd be a horrible mess difficult to understand). Sure, it might had been formatted better at the time it was actually merged. But changing it "just because" after being in tree for long time doesn't fix any problem really.
OK, thanks. I have replied the related contents in the other thread. Welcome any ideas, suggestions, and completions in the other related thread. Thanks. -- Chen Gang (e??a??) Managing Natural Environments is the Duty of Human Beings. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>