Re: [PATCH 3/5] oom: clear TIF_MEMDIE after oom_reaper managed to unmap the address space
From: Michal Hocko <mhocko@kernel.org>
Date: 2016-02-15 20:47:44
Also in:
lkml
On Sat 06-02-16 20:23:43, Tetsuo Handa wrote:
Michal Hocko wrote:
[...]
By always waking the OOM reaper up, we can delegate the duty of unlocking the OOM killer (by clearing TIF_MEMDIE or some other means) to the OOM reaper because the OOM reaper is tracking all TIF_MEMDIE tasks.
And again, I didn't say this would be incorrect. I am just saying that this will get more complex if we want to handle all the cases properly.
quoted
I would like to target the next merge window rather than have this out of tree for another release cycle which means that we should really focus on the current functionality and make sure we haven't missed anything. As there is no fundamental disagreement to the approach all the rest are just technicalities.Of course, we can target the OOM reaper for the next merge window. I'm suggesting you that my changes would help handling corner cases (bugs) you are not paying attention to.
I am paying attention to them. I just think that incremental changes are preferable and we should start with simpler cases before we go further steps. There is no reason to rush this. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>