Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure
From: David Vrabel <hidden>
Date: 2016-01-21 10:46:05
Also in:
kernel-janitors, lkml
On 23/12/15 21:06, Julia Lawall wrote:
The cleancache_ops structure is never modified, so declare it as const. This also removes the __read_mostly declaration on the cleancache_ops variable declaration, since it seems redundant with const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <redacted> --- Not sure that the __read_mostly change is correct. Does it apply to the variable, or to what the variable points to?
The variable, so...
quoted hunk ↗ jump to hunk
--- a/mm/cleancache.c +++ b/mm/cleancache.c@@ -22,7 +22,7 @@ * cleancache_ops is set by cleancache_register_ops to contain the pointers * to the cleancache "backend" implementation functions. */ -static struct cleancache_ops *cleancache_ops __read_mostly; +static const struct cleancache_ops *cleancache_ops;
...you want to retain the __read_mostly here. David -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>