Hi tj,

On 01/09/2016 02:28 AM, Tejun Heo wrote:

Hello,

On Thu, Jan 07, 2016 at 12:20:21PM +0800, Tang Chen wrote:

quoted

+static void __init init_memory_less_node(int nid)
  {
+	unsigned long zones_size[MAX_NR_ZONES] = {0};
+	unsigned long zholes_size[MAX_NR_ZONES] = {0};

It doesn't cause any functional difference but it's a bit weird to use
{0} because it explicitly says to initialize the first element to 0
when the whole array needs to be cleared.  Wouldnt { } make more sense?

Yes. Will fix them.

quoted

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index e23a9e7..9c4d4d5 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h

@@ -736,6 +736,7 @@ static inline bool is_dev_zone(const struct zone *zone)
  
  extern struct mutex zonelists_mutex;
  void build_all_zonelists(pg_data_t *pgdat, struct zone *zone);
+void build_zonelists(pg_data_t *pgdat);

This isn't used in this patch.  Contamination?

Sorry, I tried to build zone lists here. But it totally unnecessary and 
led to some problems.

I forgot to remove them when I fixed the problems. Will remove them.

Thx.

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>