Thread (36 messages) 36 messages, 7 authors, 2016-02-01

Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy()

From: "Luck, Tony" <tony.luck@intel.com>
Date: 2016-01-12 00:26:48
Also in: lkml

On Fri, Jan 08, 2016 at 05:49:30PM -0800, Andy Lutomirski wrote:
Also, what's the sfence for?  You don't seem to be using any
non-temporal operations.
So I deleted the "sfence" and now I just have a comment
at the 100: label.

37:
        shl $6,%ecx
        lea -48(%ecx,%edx),%edx
        jmp 100f
38:
        shl $6,%ecx
        lea -56(%ecx,%edx),%edx
        jmp 100f
39:
        lea (%rdx,%rcx,8),%rdx
        jmp 100f
40:
        mov %ecx,%edx
100:
        /* %rax set the fault number in fixup_exception() */
        ret

Should I just change all the "jmp 100f" into "ret"?  There
aren't any tools that will be confused that the function
has 10 returns, are there?

-Tony

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help