Re: [PATCH] mm,oom: Exclude TIF_MEMDIE processes from candidates.
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: 2016-01-07 15:38:51
Also in:
lkml
Michal Hocko wrote:
quoted hunk ↗ jump to hunk
@@ -333,6 +333,14 @@ static struct task_struct *select_bad_process(struct oom_control *oc, if (points == chosen_points && thread_group_leader(chosen)) continue; + /* + * If the current major task is already ooom killed and this + * is sysrq+f request then we rather choose somebody else + * because the current oom victim might be stuck. + */ + if (is_sysrq_oom(sc) && test_tsk_thread_flag(p, TIF_MEMDIE)) + continue; + chosen = p; chosen_points = points; }
Do we want to require SysRq-f for each thread in a process?
If g has 1024 p, dump_tasks() will do
pr_info("[%5d] %5d %5d %8lu %8lu %7ld %7ld %8lu %5hd %s\n",
for 1024 times? I think one SysRq-f per one process is sufficient.
How can we guarantee that find_lock_task_mm() from oom_kill_process()
chooses !TIF_MEMDIE thread when try_to_sacrifice_child() somehow chose
!TIF_MEMDIE thread? I think choosing !TIF_MEMDIE thread at
find_lock_task_mm() is the simplest way.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>