Re: [PATCH v2] ARM: mm: flip priority of CONFIG_DEBUG_RODATA
From: Kees Cook <hidden>
Date: 2016-01-04 20:34:31
Also in:
linux-arm-kernel, lkml
On Wed, Dec 23, 2015 at 4:34 PM, Russell King - ARM Linux [off-list ref] wrote:
On Wed, Dec 23, 2015 at 04:11:22PM -0800, Tony Lindgren wrote:quoted
* Nicolas Pitre [off-list ref] [151223 13:45]:quoted
We fixed a bunch of similar issues where code was located in the .data section for ease of use from assembly code. See commit b4e61537 and d0776aff for example.Thanks hey some assembly fun for the holidays :) I also need to check what all gets relocated to SRAM here. In any case, seems like the $subject patch is too intrusive for v4.5 at this point.Given Christmas and an unknown time between that and the merge window actually opening, I decided Tuesday would be the last day I take any patches into my tree - and today would be the day that I drop anything that causes problems. So, I've already dropped this, so tomorrow's linux-next should not have this change. You'll still see breakage if people enable RODATA though, but that's no different from previous kernels.
Ugh, sorry for the breakage. Should this patch stay as-is and people will fix their various RODATA failures during the next devel window, or should I remove the "default y if CPU_V7"? -Kees -- Kees Cook Chrome OS & Brillo Security -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>