Re: [PATCH] dax, pmem: add support for msync
From: Christoph Hellwig <hch@lst.de>
Date: 2015-08-31 19:06:19
Also in:
linux-fsdevel, lkml, nvdimm
From: Christoph Hellwig <hch@lst.de>
Date: 2015-08-31 19:06:19
Also in:
linux-fsdevel, lkml, nvdimm
On Mon, Aug 31, 2015 at 12:59:44PM -0600, Ross Zwisler wrote:
For DAX msync we just need to flush the given range using wb_cache_pmem(), which is now a public part of the PMEM API. The inclusion of <linux/dax.h> in fs/dax.c was done to make checkpatch happy. Previously it was complaining about a bunch of undeclared functions that could be made static.
Should this be abstracted by adding a ->msync method? Maybe not worth to do for now, but it might be worth to keep that in mind. Otherwise this looks fine to me. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>