Re: vm_flags, vm_flags_t and __nocast
From: Kirill A. Shutemov <hidden>
Date: 2015-08-03 15:52:00
From: Kirill A. Shutemov <hidden>
Date: 2015-08-03 15:52:00
David Rientjes wrote:
On Fri, 24 Jul 2015, Kirill A. Shutemov wrote:quoted
sparse complains on each and every vm_flags_t initialization, even with proper VM_* constants. Do we really want to fix that? To me it's too much pain and no gain. __nocast is not beneficial here. And I'm not sure that vm_flags_t typedef was a good idea after all. Originally, it was intended to become 64-bit one day, but four years later it's still unsigned long. Plain unsigned long works fine for other bit field. What is special about vm_flags?Maybe remove the __nocast until it's a different type? Seems like all these sites would have to be audited when that happens anyway.