Re: [PATCH] mm/cma_debug: Check return value of the debugfs_create_dir()
From: Michal Nazarewicz <hidden>
Date: 2015-08-27 15:38:19
Also in:
lkml
On Tue, Aug 25 2015, Alexander Kuleshov wrote:
The debugfs_create_dir() function may fail and return error. If the root directory not created, we can't create anything inside it. This patch adds check for this case. Signed-off-by: Alexander Kuleshov <redacted>
I’d also add a pr_warn but otherwise: Acked-by: Michal Nazarewicz <redacted>
quoted hunk ↗ jump to hunk
--- mm/cma_debug.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/mm/cma_debug.c b/mm/cma_debug.c index f8e4b60..bfb46e2 100644 --- a/mm/cma_debug.c +++ b/mm/cma_debug.c@@ -171,6 +171,9 @@ static void cma_debugfs_add_one(struct cma *cma, int idx) tmp = debugfs_create_dir(name, cma_debugfs_root); + if (!tmp) + return; + debugfs_create_file("alloc", S_IWUSR, tmp, cma, &cma_alloc_fops);
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, ミハウ “mina86” ナザレヴイツ (o o) ooo +--[off-list ref]--<xmpp:mina86@jabber.org>-----ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>