Re: [PATCH 04/11] ARCv2: mm: THP support
From: Kirill A. Shutemov <hidden>
Date: 2015-08-27 15:33:00
Also in:
linux-arch, lkml
From: Kirill A. Shutemov <hidden>
Date: 2015-08-27 15:33:00
Also in:
linux-arch, lkml
On Thu, Aug 27, 2015 at 02:33:07PM +0530, Vineet Gupta wrote:
+pgtable_t pgtable_trans_huge_withdraw(struct mm_struct *mm, pmd_t *pmdp)
+{
+ struct list_head *lh;
+ pgtable_t pgtable;
+ pte_t *ptep;
+
+ assert_spin_locked(&mm->page_table_lock);
+
+ pgtable = pmd_huge_pte(mm, pmdp);
+ lh = (struct list_head *) pgtable;
+ if (list_empty(lh))
+ pmd_huge_pte(mm, pmdp) = (pgtable_t) NULL;
+ else {
+ pmd_huge_pte(mm, pmdp) = (pgtable_t) lh->next;
+ list_del(lh);
+ }Side question: why pgtable_t is unsigned long on ARC and not struct page * or pte_t *, like on other archs? We could avoid these casts. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>