Thread (19 messages) 19 messages, 4 authors, 2015-09-22
STALE3934d

[PATCH 01/10] mm: make cleancache.c explicitly non-modular

From: Paul Gortmaker <hidden>
Date: 2015-08-24 22:15:48
Also in: lkml
Subsystem: memory management, the rest · Maintainers: Andrew Morton, Linus Torvalds

The Kconfig currently controlling compilation of this code is:

config CLEANCACHE
        bool "Enable cleancache driver to cache clean pages if tmem is present"

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modularity so that when reading the
driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

Cc: Konrad Rzeszutek Wilk <redacted>
Cc: linux-mm@kvack.org
Signed-off-by: Paul Gortmaker <redacted>
---
 mm/cleancache.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/cleancache.c b/mm/cleancache.c
index 8fc50811119b..ee0646d1c2fa 100644
--- a/mm/cleancache.c
+++ b/mm/cleancache.c
@@ -11,7 +11,7 @@
  * This work is licensed under the terms of the GNU GPL, version 2.
  */
 
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/fs.h>
 #include <linux/exportfs.h>
 #include <linux/mm.h>
@@ -316,4 +316,4 @@ static int __init init_cleancache(void)
 #endif
 	return 0;
 }
-module_init(init_cleancache)
+device_initcall(init_cleancache)
-- 
2.5.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help