Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()
From: Dan Streetman <hidden>
Date: 2015-06-10 21:00:16
Also in:
lkml
On Tue, Jun 9, 2015 at 8:04 AM, Sergey Senozhatsky [off-list ref] wrote:
zpool_destroy_pool() does not tolerate a NULL zpool pointer argument and performs a NULL-pointer dereference. Although there is only one zpool_destroy_pool() user (as of 4.1), still update it to be coherent with the corresponding destroy() functions of the remainig pool-allocators (slab, mempool, etc.), which now allow NULL pool-pointers. For consistency, tweak zpool_destroy_pool() and NULL-check the pointer there. Proposed by Andrew Morton. Signed-off-by: Sergey Senozhatsky <redacted> Reported-by: Andrew Morton <akpm@linux-foundation.org> LKML-reference: https://lkml.org/lkml/2015/6/8/583
Acked-by: Dan Streetman <redacted>
quoted hunk ↗ jump to hunk
--- mm/zpool.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/mm/zpool.c b/mm/zpool.c index bacdab6..2f59b90 100644 --- a/mm/zpool.c +++ b/mm/zpool.c@@ -202,6 +202,9 @@ struct zpool *zpool_create_pool(char *type, char *name, gfp_t gfp, */ void zpool_destroy_pool(struct zpool *zpool) { + if (unlikely(!zpool)) + return; + pr_info("destroying pool type %s\n", zpool->type); spin_lock(&pools_lock); --2.4.3.368.g7974889 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>