Re: [PATCH v5 2/7] vfs: Define new syscalls preadv2,pwritev2
From: Jeff Moyer <hidden>
Date: 2014-11-06 23:25:50
Also in:
linux-api, linux-arch, linux-fsdevel, lkml
Possibly related (same subject, not in this thread)
- 2014-11-05 · [PATCH v5 2/7] vfs: Define new syscalls preadv2,pwritev2 · Milosz Tanski <hidden>
Milosz Tanski [off-list ref] writes:
quoted hunk
New syscalls that take an flag argument. This change does not add any specific flags. Signed-off-by: Milosz Tanski <redacted> Reviewed-by: Christoph Hellwig <hch@lst.de> --- fs/read_write.c | 176 ++++++++++++++++++++++++++++++-------- include/linux/compat.h | 6 ++ include/linux/syscalls.h | 6 ++ include/uapi/asm-generic/unistd.h | 6 +- mm/filemap.c | 5 +- 5 files changed, 158 insertions(+), 41 deletions(-)diff --git a/fs/read_write.c b/fs/read_write.c index 94b2d34..907735c 100644 --- a/fs/read_write.c +++ b/fs/read_write.c@@ -866,6 +866,8 @@ ssize_t vfs_readv(struct file *file, const struct iovec __user *vec, return -EBADF; if (!(file->f_mode & FMODE_CAN_READ)) return -EINVAL; + if (flags & ~0) + return -EINVAL; return do_readv_writev(READ, file, vec, vlen, pos, flags); }@@ -879,21 +881,23 @@ ssize_t vfs_writev(struct file *file, const struct iovec __user *vec, return -EBADF; if (!(file->f_mode & FMODE_CAN_WRITE)) return -EINVAL; + if (flags & ~0) + return -EINVAL; return do_readv_writev(WRITE, file, vec, vlen, pos, flags); }
Hi, Milosz, You've checked for invalid flags for the normal system calls, but not for the compat variants. Can you add that in, please? Thanks! Jeff -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>