Re: [PATCH v3] kvm: Fix page ageing bugs

On Mon, Sep 22, 2014 at 2:48 PM, Paolo Bonzini [off-list ref] wrote:

Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto:

quoted

+             __entry->gfn            = gfn;
+             __entry->hva            = ((gfn - slot->base_gfn) >>

This must be <<.

Correct, thanks.

quoted

+                                         PAGE_SHIFT) + slot->userspace_addr;

quoted

+             /*
+              * No need for _notify because we're called within an
+              * mmu_notifier_invalidate_range_ {start|end} scope.
+              */

Why "called within"?  It is try_to_unmap_cluster itself that calls
mmu_notifier_invalidate_range_*, so "we're within an
mmu_notifier_invalidate_range_start/end scope" sounds better, and it's
also what you use in the commit message.

Also correct. V4...
Andres

Paolo

-- 
Andres Lagar-Cavilla | Google Kernel Team | andreslc@google.com

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>